osTicket Community Forums

Template Variables Replacement Bug

In class.ticket, there are three instances in which the %message variable is replaced AFTER the replaceTemplateVars() function has already executed. In order for template variables to be properly replaced, the %message variable would have to be replaced BEFORE replaceTemplateVars() is executed, otherwise none of the template placeholders would be visible to the replaceTemplateVars() function.

Normally, this does not cause a problem, since when you reply to a ticket, the template variables are replaced using an AJAX function, before the ticket is even created. However, when a staff member creates a new ticket, the AJAX function will not perform the replacement, since the ticket does not yet exist and therefore there is nothing to replace.

To correct this problem, you simply have to move the %message variable replacement line up by a few lines, so it executes before the replaceTemplateVars() function executes. There is one instance of this in the create_by_staff() method and two instances in the create() method.